This repository has been archived by the owner on Sep 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
Feature: Introduce new payload parameters #29
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In release 0.7.0 of GCR Cleaner tool, there was an introduction of new parameters: > This release introduces a new mechanism for deleting tagged images. You can now specify tag_filter_all or tag_filter_any to control how the filters match against images with multiple tags. The existing behavior of tag_filter is preserved, but will be removed in a future release. Additionally, specifying allow_tagged is no longer necessary as specifying any tag filter will automatically activate deleting tagged images. More on https://github.com/GoogleCloudPlatform/gcr-cleaner/releases/tag/v0.7.0 Also in this PR: * Updating examples * Updating documentation * Updating pre-commit repos URLs: using https:// instead of git://. See https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more details
madhifallah
approved these changes
Jan 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
elagree
reviewed
Jan 11, 2022
elagree
reviewed
Jan 11, 2022
elagree
approved these changes
Jan 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
tbeaugrand
reviewed
Jan 11, 2022
tbeaugrand
reviewed
Jan 11, 2022
tbeaugrand
approved these changes
Jan 11, 2022
mirakl-admin
pushed a commit
that referenced
this pull request
Feb 3, 2022
## 1.0.0 (2022-02-03) ### Features * Add support for GCR buckets with uniform_bucket_level_access = true ([#32](#32)) ([16d6232](16d6232)) * First Implementation of GCR Cleaner ([#1](#1)) ([5ad9957](5ad9957)) * Implement dry_run to easily list images to delete ([#34](#34)) ([b5bb78a](b5bb78a)) * Implementing all payload parameters ([#24](#24)) ([dde3658](dde3658)) * Implementing get all repositories of a given project ([#3](#3)) ([f043971](f043971)) * Introduce new payload parameters ([#29](#29)) ([0ea8b25](0ea8b25)) ### Bug Fixes * Adding repos parameter to payload ([#27](#27)) ([0b62c57](0b62c57)), closes [#24](#24) ### Reverts * Revert "add support for gcr buckets with uniform_bucket_level_access = true (#30)" (#31) ([9eb0fde](9eb0fde)), closes [#30](#30) [#31](#31)
mirakl-admin
pushed a commit
that referenced
this pull request
Feb 3, 2022
## 1.0.0 (2022-02-03) ### Features * Add basic Google Artifact Registry support ([#39](#39)) ([8d6ba49](8d6ba49)) * Add support for GCR buckets with uniform_bucket_level_access = true ([#32](#32)) ([16d6232](16d6232)) * First Implementation of GCR Cleaner ([#1](#1)) ([5ad9957](5ad9957)) * Implement dry_run to easily list images to delete ([#34](#34)) ([b5bb78a](b5bb78a)) * Implementing all payload parameters ([#24](#24)) ([dde3658](dde3658)) * Implementing get all repositories of a given project ([#3](#3)) ([f043971](f043971)) * Introduce new payload parameters ([#29](#29)) ([0ea8b25](0ea8b25)) ### Bug Fixes * Adding repos parameter to payload ([#27](#27)) ([0b62c57](0b62c57)), closes [#24](#24) ### Reverts * Revert "add support for gcr buckets with uniform_bucket_level_access = true (#30)" (#31) ([9eb0fde](9eb0fde)), closes [#30](#30) [#31](#31)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In release 0.7.0 of GCR Cleaner tool, there was an introduction of new parameters:
Also in this PR:
for more details